Maidens of the Kaleidoscope

~Hakurei Shrine~ => Rika and Nitori's Garage Experiments => Touhou Projects => Topic started by: yoshimo on June 23, 2016, 03:38:15 AM

Title: [DORMANT] Shining Shooting Star Accessibility Patch: Polished Shooting Star
Post by: yoshimo on June 23, 2016, 03:38:15 AM
I AM NOT ACTIVELY WORKING ON THIS ANYMORE. IF ANYONE WANTS TO MAKE THEIR OWN PATCH, I WILL NOT STOP YOU.
BELOW IS THE OP AS IT WAS BEFORE THIS PROJECT WAS PUT INTO DORMANCY.


WARNING: ANY REPLAYS WHICH WERE NOT CREATED IN A SPECIFIC PATCHED GAME MIGHT DESYNCH.
WARNING 2: The patch is always changing! New bugs are discovered every once in a while, so this means that the patch might have issues! Feedback about any issues are encouraged! I also encourage users to check back for new updates regularly and update as soon as you can when a new version is available.

This patch allows you to run Shining Shooting Star without having to run it using certain locale settings.
It also resolves some issues regarding system-specific interpretations.
It ALSO makes translating all scenarios, endings, and music comments possible for certain languages and easier for others! See the end of this post for examples.

IMPORTANT: This is NOT meant to be a language patch! This is meant to make the game accessible to other locales and Windows systems, and to make translations simpler (or in some cases, possible) for other languages.

Permissions on use in other projects:
Are you trying to make a translation patch for the game and want this? Be my guest! I only wish that you credit me and let me know you are using it!
Otherwise, I ask that you contact me first!

Should work with:

Has issues with (see issues not fixed below):

Let me know if it works for or has issues with another language!

Download:
Current Version: 0.4.1a
ALERT: After waiting patiently for a response, I have acquired permission from the original game creator to distribute their game with the patch installed! No more fumbling with patchers!
You can download the patch from here (https://github.com/yoshiweegee/PolishedShootingStar)!
Just make sure you extract everything before you try doing anything else with this and READ THE INCLUDED TEXT FILE!

PLEASE! If you have ANY issues with this patch and the text file's troubleshooting tips do not help, alert me! The goal is to make this game be internationally accessible to both players and translators, so if there is a problem with the patch, it is my responsibility to fix it! :D


PSSSETTING INI DETAILS



Issues not fixed by the patch:

Special thanks - Those marked with an asterisk (*) were of great help:

Changelog (https://docs.google.com/document/d/1hd4_2jo0U6IXDwBrCRN7TNdHtct9Q5ec_Ij-Kbl2VXQ/edit?usp=sharing)
Title: Re: Locale-Independency for Shining Shooting Star
Post by: Uruwi on June 23, 2016, 02:07:56 PM
If you want to see if the replays are still synchronized, try replaying one of the scoreruns on the main thread and see if the scores match.
Title: Re: Locale-Independency for Shining Shooting Star
Post by: yoshimo on June 24, 2016, 02:47:33 AM
Thank you for the suggestion, Uruwi.

I watched a replay  to the point that it would not be spoilers for me. It did not desyncronize, so that's a good sign.

I have also begun seeking distribution permissions. I'm not going to elaborate; I just want to make it clear I am working towards a distribution.
Title: Re: Shining Shooting Star Compatibility Project: "Polished Shooting Star"
Post by: yoshimo on June 24, 2016, 05:52:48 AM
While I generally disapprove of double-posting, I feel this is important for system compatibility reasons.

I found the source of the issue with the text bounds. It should now work properly for any font.
With this, I have removed the support for line breaks as they are not needed.

Since this opens the topic from locale compatibility to other forms of polish across systems, I'm going to change the topic name to reflect this.

"Polished Shooting Star" is now my name for this project.
Title: Re: Shining Shooting Star Compatibility Project: "Polished Shooting Star"
Post by: Uruwi on June 24, 2016, 06:22:14 AM
You know you can edit your posts, right?
Title: Re: Shining Shooting Star Compatibility Patch: "Polished Shooting Star"
Post by: YuyuKoishi7 on June 25, 2016, 04:55:28 PM
I used the patch, well the game worked but not in a good way. xD
https://www.youtube.com/watch?v=VruQ6XsiNYc
Watch that video, the same happenes to me when I patched the game lol.
Maybe it is an error on my side, do you know how to make it work properly?
And sorry if Im sending this wrong, I just create this account to send this message. Keep up the good work!
Title: Re: Shining Shooting Star Compatibility Patch: "Polished Shooting Star"
Post by: RegalStar on June 25, 2016, 10:46:16 PM
Now I can enter the game without it crashing, but it still crashes as soon as stage 1 boss shows up at the end (not as a midboss).

Also, after the loading screen it pops up an error saying something like "error while creating altar models (祭坛模型产生时出错)". I'm assuming thta it's talking about the files in the Model folder, which contains images with Chinese names.

And yes, I made sure that all pathnames to the game and the patch files (which I just copied straight into the game folder) have no non-latin characters.
Title: Re: Shining Shooting Star Compatibility Patch: "Polished Shooting Star"
Post by: yoshimo on June 25, 2016, 11:24:15 PM
If you downloaded v1.0, I accidentally uploaded the wrong patch. It will not work correctly.

If you downloaded v1.0.1, I'm not exactly sure what the problem is. I'm looking into it right now to see if I screwed up again. :ohdear:

I want to apologize for this. This is what happens when you try to distribute things at 5:00 in the morning.

EDIT: I just applied the v1.0.1 patch on my end, and it seems to work fine. If you are using the v1.0.1 patch, may you tell me what your system locale is? This will allow me to experiment and debug further. You can see how to check it here (http://fuwanovel.net/faq/setting-windows-to-japanese-locale).

RegalStar, I do recognize the first error you are talking about. The error regarding the models should have been fixed (see Model_Mesh.cs changes), but the boss causing crashes would be related to conversations, which I can only imagine crashing if you have a translation applied that has commas in it not surrounded by quotation marks or if your locale encodes to something which for some reason includes a comma.

ANOTHER EDIT: Sorry, Yuyu, I didn't see you at first! To be honest, while that is hilarious minus the crash, it's unintended, I honestly have no idea why it happens. I would also recommend letting me know your system locale so I may investigate further.
Title: Re: Shining Shooting Star Compatibility Patch: "Polished Shooting Star"
Post by: YuyuKoishi7 on June 26, 2016, 02:14:01 AM
I tried downloading again, and the same glitch happened, to me it is hilarious how the fairies spawns and how it crashes in the most calm part of the song. xD

My locale system is Japanese from what I can see. I hope you can find a solution.  :)
Title: Re: Shining Shooting Star Compatibility Patch: "Polished Shooting Star"
Post by: yoshimo on June 26, 2016, 02:54:09 AM
YuyuKoishi, I do not seem to experience your issues. The enemies appear to move fine and the midboss loads just fine. Let me know if you can think of anything about your system that may help me discover the issue.
I do want to ask: is it correct that you are playing on a Windows operating system? If so, what version? The video you gave me had what appeared to be an older version of Windows.


I have confirmed RegalStar's issues. They seem to be related to how the Japanese encoding works. The encoding, for reference, is code page 932, "Shift-JIS." The problem is that the encoding for Shift-JIS absorbs some of the commas in the CSV conversations. These commas are necessary for splitting the text correctly, meaning that it will be read wrong if the commas are absorbed. This is why the game crashes trying to load certain scenarios. I'm looking for a solution right now.

As for the model loading error, I have not yet looked into that, but I suspect it's a similar issue.
EDIT: So it turns out Shift-JIS absorbs periods as well! Thus, the file names lose the period necessary to define their extension. Suppose you have an image called "something.bmp". Shift-JIS may decide to eat the period and spit out "<something in japanese>bmp". notice the period is gone. This is strange and at the graphics setup level, so the fix might be very difficult.
Title: Re: Shining Shooting Star Compatibility Patch: "Polished Shooting Star"
Post by: YuyuKoishi7 on June 26, 2016, 04:39:41 AM
I play on Windows 7. It sounds so complex! Just to be sure, which locale do you use? Maybe I should switch to the one you use in order to make it work?
Title: Re: Shining Shooting Star Compatibility Patch: "Polished Shooting Star"
Post by: yoshimo on June 26, 2016, 07:13:37 AM
I use the English (United States) locale. I know that works. I have not received confirmation or negation on other locales other than the Japanese locale.
If you're going to switch to a different locale, you may as well just switch to Simplified Chinese and play the game without the patch unless you want the text box bounding to work.

Also, I have found more information regarding the Japanese locale issues. It appears the encoding does not support certain bytes that are passed to it. As a failsafe, it changes the bytes to something else. I'm not sure how it gets to the "something else." What I do know is that it ruins the string in a way that cannot be easily fixed. In fact, it might be impossible to fix, as you really can't get back lost text. I am considering implementing language-specific fixes, but that would be really inefficient; however, it is increasingly seeming to be the best fix.
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star v1.0.2
Post by: yoshimo on June 26, 2016, 09:12:37 PM
IMPORTANT UPDATE!

The Japanese locale (hopefully) is now supported! I spent an entire day figuring a fix for you guys; be happy! :3

I also implemented a very important fix that affects all locales. Model loading didn't work correctly on locales other than English. This would cause issues in certain stages, and will probably cause a crash!
Because of this, I highly recommend all users update their patch to version 1.0.2! Check the original post for the download!

Side note to YuyuKoishi: I cannot replicate the issue that you report having, so I cannot look for a fix right now. Once I find a pattern with those who suffer the problem, I will immediately look for a fix!
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star v1.0.2
Post by: RegalStar on June 27, 2016, 05:50:11 AM
(Japanese locale) Now the game will run all the way to the final boss, but it seems that loading the ending still causes a crash.

Less seriously, all conversations are now gibberish.
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star v1.0.2
Post by: yoshimo on June 27, 2016, 06:02:54 AM
Darn, I was really hoping I wouldn't have to deal with spoiling content. I will look into this immediately.

The garbage text is normal as it's supposed to be decoded by the Chinese locale, but it's being decoded in UTF-8. This is done simply to prevent certain locales from crashing. A translation patch should resolve the problem as long as it's compatible with my patch.

I am very sorry with the inadequate amount of testing I am doing. I am prioritizing this project over playing the game myself, so I don't test the game fully as I've only gotten to Stage 4.
I will update the OP to explain that there are still issues.

I'd also like to personally apologize if you were doing a legitimate run and this happened. I was really hoping something like that would never happen; it may as well be my worst nightmare is respect to this project.

EDIT: Okay, this is actually very bad. This is so bad, I'm pulling the download off the original post. Encoding.Default is actually used in many places.This means a lot of data get decoded differently in several different aspects of the game. THE PLAYER SCORES ARE SAVED THIS WAY, which means that any .dat files people share MIGHT NOT BE COMPATIBLE ACROSS LOCALES. I will put the download back once I can eliminate all of these issues, because there's nothing worse than segregating a game community.

EDIT 2: Maybe not as bad as I initially thought. Player data seems to load fine no matter what the locale is due to the characters used for it being near universal. I am however staying wary of it.

EDIT 3: I am NOT playing through the whole game just to debug a crash. Let me take a shortcut and give myself a boost. ;)
...Even with the boost, I'm absolute trash and beating her is difficult.

FINAL EDIT: After struggling with beating this woman (Don't take that out of context!) for at least an hour, I believe I may have fixed the issue. I made seemingly appropriate changes to the several locations where the default encoding was used, and I do not receive a crash when the ending loads on either English or Japanese locales. Before you ask, no, I am not debugging other locales right now. I will debug a locale once someone reports there being an issue with it, as YuyuKoishi and RegalStar did.
Before I distribute this new release candidate, I need to do some final checks, but I will need time to do that.
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC2.0 [BROKEN]
Post by: RegalStar on June 27, 2016, 01:53:34 PM
(Japanese locale) I tried playing with other characters. It seems that Marisa and Sanae gives properly encoded Chinese text on boss conversations, but both will crash on stage 4 midboss. Koishi crashes on Stage 1 boss.

(And wow, is Koishi supposed to have that kind of range with her unfocused shot?)

EDIT: I guess this post already makes it pretty clear, but my previous post's experience was with Reimu/Shinmyoumaru.

EDIT2: It turns out that stage 4 doesn't have a midboss. So I guess Marisa/Sanae crashes on stage 4 boss.
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC2.0 [BROKEN]
Post by: yoshimo on June 27, 2016, 11:00:05 PM
Yes, this exactly matches what I found. There are two different methods for loading text from the CSV files. The areas you describe crashing are the parts where it tries to use the method I did not fix.

With this information acquired, I feel it should be safe to release the next update, but I first need time to prepare the original post.
EDIT 2: RC3.0 is now available!

Thank you for your patience and assistance, RegalStar!

EDIT: Wow, I almost forgot to remove the boost I gave myself for debugging purposes. Imagine playing as Reimu & Shinmyoumaru and starting at Stage 6 with 8 lives, 8 spellcards, and 4.00 power. I'm glad I remembered to remove it before I released it.
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC3.0
Post by: RegalStar on June 28, 2016, 12:28:56 AM
I tested a complete playthrough of Reimu/Shinmyoumaru and there were no problems.

Thank you for writing this patch.
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC3.0
Post by: Totalheartsboy on June 28, 2016, 02:08:18 AM
This patch is very helpful, thank you so much ;3!~
Now i don't have to change the locale.


Oftopic:Btw, do you know what are the names for the numpad keys(8,4,6,2) im left-handed and the regular arrows are not working













Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC3.0
Post by: yoshimo on June 28, 2016, 03:09:11 AM
I'm glad to hear the patch is working for both of you!


There is another program that comes with Shining Shooting Star called Config. This program seems to run fine without a locale switch for me, but considering all of the problems I've seen with the Japanese locale, I can imagine it not working for some locales.

If you can run Config, you can do what is show in this picture.
Quote
(http://image.prntscr.com/image/e439160547644463938189830da437c6.png)
EDIT: F8 is actually "Change Window Size." This will cycle along 640x480, 800x600, 1024x768, and fullscreen.
Make sure the NumLock is enabled, or it won't enter the NumPad numbers.

If you can't, you can edit the Setting INI, which I assume is what you are trying to do. The name of the numpad keys are "NumPad<#>" where <#> is the number.

Make sure the NumLock is enabled while you play, otherwise neither method will work.
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC3.0
Post by: YuyuKoishi7 on June 28, 2016, 01:27:26 PM
This is weird! I tried the 3.0 patch (Btw thank you so much for taking the time to do this!) on my friend's PC and it work completely fine, but then I try it on mine and the same error happens (The one I show you on the video before)... Maybe my PC is the problem, idk I give up, this is weird. XD

I'm looking forward for next RC of this patch, and hopefully it works so I can give you feedback.  :) Stay awesome!

Edit: I'm going to record how the games looks like when you try it on Lunatic after patching, its hilarious! 😂😂😂
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC3.0
Post by: yoshimo on June 28, 2016, 02:06:56 PM
I truly wish I knew what the issue was regarding your error. My patch aims for compatibility, and this error is making the game not compatible! I will keep my eyes open for a solution.

Here's an update on my current plans. The conversations for Stages 1 - 3 for Marisa's and Sanae's scenarios are not easily modifiable for translators. My goal is to change that.
I already have Stage 1's conversations accessible, but I need to focus on college for a while, so I can't push the update any time soon.
This next update will require more than just patching the game; it will also require the user to add some files to prevent crashes. This is just a heads-up.
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC3.0
Post by: YuyuKoishi7 on June 28, 2016, 04:34:30 PM
It's okey, you are doing more than enought by creating this patch! I wish you good luck on your college.

Oh and here is the video, Idk why it is so funny how the game crashes when Koishi is in front of a Fairy.  xD
https://www.youtube.com/watch?v=IPeM05fKr-0

EDIT: I copied my save filed into the glitched game (Lets call it Broken Shooting Star) and I tried some levels on hard and normal to see how affected is the game, and its even more hilarious. I will upload another video, maybe that would give you a clue of wat the problem is (And also make you laught a bit xD)
Here is the video:
https://www.youtube.com/watch?v=vSdVSjyCi2E&feature=youtu.be
I hope that madness can help you find what the problem might be.
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC3.0
Post by: RegalStar on June 28, 2016, 08:59:22 PM
My friend is reporting that the game crashes upon selecting a character, on German locale.

EDIT: Trying to view a replay will crash upon selecting a stage.
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC3.0
Post by: yoshimo on June 28, 2016, 10:57:37 PM
Still at college at the moment. On my phone.

I'm willing to bet that this is another lossy encoding issue, not unlike the model loading error on a Japanese locale; however, I think this is related to textures. I will look into it as soon as I can.

EDIT: I'm now home. I would immediately start figuring the German incompatibility, but there are two problems.



YuyuKoishi, I got around to watching your videos. All I can think of while watching them is:
Quote
(http://image.prntscr.com/image/200a848e5fc344ea80406c335cdbcba2.png)
Either way, after watching your videos, I've concluded a few things.

I finally have a hypothesis. I believe most of the data for what happens in stages in contained in certain MBG files. I'm considering looking at both their structure and how the game reads them to see if I can determine potential problems. I will try to get to this as soon as I can, but I can only do one thing at a time...

EDIT2: Nope nope nope nope nope
Quote
(http://image.prntscr.com/image/376611ba84904a45976be6a7677def5b.png)
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC3.1
Post by: yoshimo on June 29, 2016, 09:45:45 AM
Here's an update the translators will LOVE!
RC3.1 is now available!

What's new?
I fixed the bug with CSV files potentially crashing when modified, so translators now can actually START translating.
The other addition is that I have converted the hard-coded conversations to CSV conversations! Translators now can start editing Stages 1 - 3 of Marisa's and Sanae's scenarios with just a few mouse clicks!

Eh, may I make a confession?
I cannot guarantee I properly converted the hard-coded conversations. A replay of Sanae confirms no crashes happen, but I could not get a replay of Marisa.
As such, I cannot guarantee Marisa does not cause crashes, and I cannot guarantee that the conversations for either character are correct; the replays just rush through the text!
Please let me know if you spot something wrong!!

P.S. Apologies for double-post.
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC3.1
Post by: RegalStar on June 29, 2016, 01:08:25 PM
German (Switzerland)
Title: Re: Shining Shooting Star Compatibility Patch: Polished Shooting Star RC3.1
Post by: yoshimo on June 30, 2016, 01:50:46 AM
I'm really sorry to say this, but I'm not experiencing any crashes on any of the German locales.

However, I did release a new patch after you reported the issue. Perhaps one of my changes indirectly fixed the issue?


On another topic, RC3.1 of my patch requires more steps than the previous versions did. As such, my video is somewhat outdated.
I will update it as soon as I can, but I again need to focus on college work, and finding good times to record nonetheless is difficult.
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.2
Post by: yoshimo on July 03, 2016, 05:13:20 AM
RC3.2 has been released. This one is a pretty small update. The music comments now can easily be translated.

As for the other problems people experience with my patch, I am very sorry to say that I have no ideas how to approach them. It is very possible that I cannot fix them. :(
Thank you for reporting the issues. I won't forget about them, but they will have to be put on the back burner.
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.2
Post by: VierMill on July 03, 2016, 03:14:01 PM
I have a LoadBPic Error ever since I installed the game, and the game crashes whenever I choose a character.
I thought this patch would fix it, but there are no changes at all... any idea how to fix it?
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.2
Post by: yoshimo on July 03, 2016, 07:05:53 PM
That's unusual. From what I've seen,the game does not come with any BPics; the BPic folder is empty.
Do you have any files in that folder? If this is so, try removing them from the folder; though, I wouldn't delete them; they could be important.
I will also look to see what I can find in how the game loads BPics. Maybe I'll finally learn what they are.

EDIT: So, "BPic" stands for "BulletPicture." It seems that it was designed to be a generic bullet image that could be colored.
The method which loads BPics -- which is also the one that can throw the LoadBPic Error -- checks for PNG images in the "BPic" folder.
It's very obvious that the method would throw errors for any BPic. It tries to put a casted integer in a 2D array of booleans, which I highly believe would be a type mismatch. :ohdear:
If you continue to experience this problem, I'll consider making changes, but it seems like BPics were not meant to be used, so I highly suspect a PNG image found its way into your "BPic" folder.
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.2
Post by: VierMill on July 04, 2016, 09:14:32 AM
That's unusual. From what I've seen,the game does not come with any BPics; the BPic folder is empty.
Do you have any files in that folder? If this is so, try removing them from the folder; though, I wouldn't delete them; they could be important.
I will also look to see what I can find in how the game loads BPics. Maybe I'll finally learn what they are.

EDIT: So, "BPic" stands for "BulletPicture." It seems that it was designed to be a generic bullet image that could be colored.
The method which loads BPics -- which is also the one that can throw the LoadBPic Error -- checks for PNG images in the "BPic" folder.
It's very obvious that the method would throw errors for any BPic. It tries to put a casted integer in a 2D array of booleans, which I highly believe would be a type mismatch. :ohdear:
If you continue to experience this problem, I'll consider making changes, but it seems like BPics were not meant to be used, so I highly suspect a PNG image found its way into your "BPic" folder.

I've redownloaded the game some times, but it keeps happening.
Where is the BPic folder? I can't seem to be able to find it, it may be the problem...
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.2
Post by: yoshimo on July 04, 2016, 10:14:45 AM
There isn't a BPic folder? That is a problem. That is another way the error could be thrown.
If there is not a BPic folder in the same location as the game, the THSSS program, then you should make one. That should fix the LoadBPic Error.
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.2
Post by: VierMill on July 04, 2016, 11:46:35 AM
Thank you, it works now.
It's weird, the BPic folder was with the download, but for some reason it didn't show up in the installation path of the game (I extracted everything... I know because I even did it and even redownloaded it several times) I tried the game and now it finally works, now the game works both patched and unpatched.

Sorry for the trouble, it seems the problem was completely unrelated to the patch or the need to have the patch. (I was tired of trying chinese, japanese and english locales (Spanish computer))

The patch seems compatible with spanish language systems (Since I think I did read it may not be compatible with all), though I barely had time to start playing, so I may get crashes later, thank you again for the help

EDIT: Patched crashed somewhere mid-way stage 1 (with Marisa), I guess it couldn't last... non-patched with chinese locale lags less with inputs, but still crashes at the same point. I guess I'll give up or try to get help later at this game's thread.
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.2
Post by: yoshimo on July 04, 2016, 10:59:41 PM
Since you've told me the locale, I can try to replicate the issue and see if I can identify the problem.

You say it crashes midway through Stage 1 while playing as Marisa. Does this happen with other characters? Is it when the midboss shows?

EDIT: I was unable to replicate what you mentioned; however, I've heard that other people experience a similar problem.
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.3
Post by: Sonrio on August 14, 2016, 10:02:44 PM
Hello! I made an account to ask something regarding a bug that I think is related to the crashing you mentioned earlier.

I recently completed the game with Koishi (as in 1ccd) on Normal and yesterday made it to the final boss with Reimu on Hard. However, I played as Marisa and Sanae today on Hard. Marisa's run crashed when the Stage 2 boss appeared at the end, and Sanae's run keeps crashing when the Stage 1 boss appears. I tried Sanae again on Normal and the same thing happened at the end of Stage 1.

What's strange is that these are only two characters that crash. I tried playing Koishi and Reimu again and they seemed to be fine (I stopped at the beginning of Stage 3 for both though). I'm not sure if it's because of the patch because I did patch it with Polished Shooting Star + the current English Patch. Do you have any ideas?
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.3
Post by: yoshimo on August 15, 2016, 05:11:31 AM
Did you remember to merge the included BGM and Story folders? The game might be crashing because you don't have the files my patch is trying to load.

Here are some clear illustrations that will tell you if you forgot this step.

Quote
Inside these folders...
(http://image.prntscr.com/image/af80c7605a6a464e85d19eaadb63524f.png)
Inside "BGM" you should have these files (and others not shown, but you should see a pattern)
(http://image.prntscr.com/image/2525a4cc1c16489e800b9bf632a0ed9a.png)
Inside "Story" you should have these files
(http://image.prntscr.com/image/0de40be4eb2b45c0a7f2a6dc218aecfa.png)

If you don't have these files, then the game will crash because it can't find them.
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.3
Post by: Sonrio on August 15, 2016, 07:17:46 PM
When I did that I had thought it meant just placing them in the folder with the game exe. Was I supposed to put them in another folder?
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.3
Post by: yoshimo on August 15, 2016, 10:19:00 PM
I posted some pictures in my previous post. Are the files I highlighted there?
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.3
Post by: Sonrio on August 16, 2016, 12:33:20 AM
Yes, they are all in there.

The game still crashes, I just tried again :/
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.3
Post by: yoshimo on August 16, 2016, 02:06:51 AM
I have identified the problem.
I forgot to put some commas in some of the conversation files.
I'll push a fix momentarily.
Sorry about the trouble!

EDIT: I can't seem to find anything wrong with Marisa's conversations. Looking into it further...
Nope, doesn't crash for me. Once I push the update, could you tell me if Marisa still crashes on Stage 2?
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.3
Post by: Sonrio on August 16, 2016, 05:02:46 AM
I applied the update and it still crashed, however it managed to get a few lines in with Rakuki before crashing this time. I guess that's a step up.

Just tried with Sanae as well; still crashes as soon as the first boss shows up at the end. Maybe I did something wrong? I could try it on a clean copy of the game later.
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.3
Post by: yoshimo on August 16, 2016, 05:43:39 AM
Well, if you tried to apply the patch on an already-patched application, that's a problem. Otherwise, I'm not exactly certain what the issue is at this point.

Would you mind telling me your computer's locale? That might help me replicate the crash.
Also, are you trying to install the English patch I made as well?
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.3.1
Post by: Sonrio on August 16, 2016, 05:46:00 AM
I'm on Japanese locale, and yes, I have the English patch installed as well.
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.3.1
Post by: yoshimo on August 16, 2016, 06:02:13 AM
Alright, I will use what you've told me to try to get the crash to occur when I can. Right now, it's getting late, and I have to focus on college work extensively over this week.

Sorry for this inconvenience. If you want to see the translations, you can find them in the translation tables I have. The link to them is in the thread for my English patch.

OH, THIS IS USEFUL.
I just found that the same typo in the file in the accessibility patch is in the English patch.
Try opening "1-1C.csv" in the "Story" folder in a text editor (Notepad should work) and adding two commas to the end of the first line. See if that fixes Sanae crashing.
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.3.1
Post by: Sonrio on August 16, 2016, 06:30:04 AM
Didn't work unfortunately.
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star RC3.3.1
Post by: yoshimo on August 21, 2016, 03:28:31 AM
So I've found that there are more typos than I originally thought.

I found another issue in Sanae's Stage 1 conversation, but only in the English patch.
I'm currently working on updating the English patch to include more up-to-date translations.
I ask for your patience.
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star
Post by: yoshimo on August 29, 2016, 07:33:05 PM
SORRY FOR THE DOUBLE POST! :ohdear:

This one's for you, Sonrio!

RC3.3.2 fixes crashing related to Marisa's Stage 2 and Sanae's Stage 1 boss conversations.

Now you can actually play through the game as them! Hooray!
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star
Post by: philipstrife on September 23, 2016, 07:21:05 PM
My game used to crash in the middle of the first stage. Then, I went to Windows Regional settings and changed the date format to English(USA). My former format was Brazilian Portuguese.
The game runs just fine now
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star
Post by: yoshimo on September 26, 2016, 03:07:10 AM
I have confirmed the presence of this bug, and HOO BOY this is interesting.

I have replicated the the bug of erratic enemies and bullets AND a crash related to the loading of bosses.

This means that thanks to you, I can now pinpoint exactly what the problem is.

I'm still bamboozled by it being caused by formats of all things.

EDIT: I may have identified the boss-crashing issue. The game converts the time remaining for a given spell or cooldown into a 1-point decimal -- only one digit to the right of the decimal point.
The problem with this is some date formats convert this to a comma rather than the expected period. As a result, the game cannot find a texture for a comma in the spellcard timer and crashes.
I'm currently looking into a fix for this. Afterwards, I'll look into the erratic enemy movement.

EDIT 2: Both bugs have been fixed. Everything was related to the differences in how different number systems use commas or periods to represent the decimal points or "-illion marks."
Crashes at bosses were related to the timer being a number with one digit past the decimal point.
Issues with enemies were related to some data being numbers with digits past the decimal point.
For example, the number "0.8" would be interpreted as "8.0." To get the desired result, it would need to be "0,8."
The number "1,000" would be interpreted as "1.0." To get the desired result, it would need to be "1.000."
This is due to the role of commas and periods in numbers being reversed in certain numbering systems.

I am going to promptly contact those who reported unusual issues to see if they still experience the issues once I have uploaded the new patch.


FINAL EDIT: Polished Shooting Star RC4.0 has been released!
This will hopefully finally fix the pesky problem of enemies and bullets not moving correctly!
It also should fix the game crashing when a midboss or boss appears!
An issue plaguing the patch for three months has finally met its demise!
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star
Post by: yoshimo on October 08, 2016, 05:13:42 AM
Double posting for an update notice.

After continuing to receive complaints of crashes and other strange issues, taking what philipstrife told me, I set out to see if I could find more related issues. Lo and behold, I found more, and they were issues people had reported in the past.

I am happy to say that all previously reported issues should be ironed out in RC4.1! This even includes a newer bug related to boss health not depleting.
I hope these new fixes will allow a whole new audience to actually play this patch!
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star
Post by: yoshimo on March 13, 2017, 06:14:43 AM
I LIVE!!

Many apologies for disappearing for so long! College has been crazy and I've been suffering my usual "demotivation syndrome."

See, what really drove me into the ground was not being able to reasonably get update to you guys, so I'm uploading my content to GitHub! Now I can make hotfixes without having to prepare an entirely new zip for you guys!

For those of you downloading this for the English patch, I will be making a GitHub for that, too.

Now, I am aware of a bug caused on some locales which causes the Extra Stage to still have erratic enemies and bullets. This one is really hidden, so I have not been able to fix it yet. I hope I can get back to finding the source of the bug, but for now, it does not prevent the player from reaching the end of the Extra Stage, so I am putting it on lower priority compared to my other projects. Keep in mind that this means that if you experience this bug, any replays you make of the Extra Stage will be desynchronized!

Give me a moment to update the OP, too!
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star
Post by: saisengen on March 20, 2017, 01:50:55 PM
Can I use Config.exe with this patch? I want to switch the game from fullscreen to window mode, but Config.exe crashes as same as game without patch itself.

UPD: it can be changed directly through Setting.INI
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star
Post by: saisengen on March 20, 2017, 04:36:59 PM
This game doesn't play other people's replays. I broke my scorefile and can't run my replays, because new empty scorefile doesn't contain info about existing replays. Yoshimo, can you fix this behaviour?
Title: Re: Shining Shooting Star Accessibility Patch: Polished Shooting Star
Post by: yoshimo on April 05, 2017, 06:13:43 PM
This patch does not affect Config.exe. I do not have plans to support this since I cannot seem to disassemble the program.

As for replays, this does not surprise me. I changed the way conversations are loaded, so it is likely that there will be discrepancies. The only reason there was no warning in the OP is because I was not certain if this did cause desynch with replays. With your complaint, I will add this warning. Unfortunately, there is no way to fix this.